Fix boundaries and add to the game code.#4
Open
buxtonpaul wants to merge 3 commits intothebracket:mainfrom
Open
Fix boundaries and add to the game code.#4buxtonpaul wants to merge 3 commits intothebracket:mainfrom
buxtonpaul wants to merge 3 commits intothebracket:mainfrom
Conversation
Author
|
In general this chapter of the book has some issues. Whilst introducing the idea of a test harness at this point makes sense, not incorporating it into the development of the code means that if we use the test harness as is then we cannot follow along easily with the book as the code we are adding is not compatible with the test harness code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the boundary code so that the boundaries are at the edge of the screen.
Add the missing boundary code to the automata code. The book specifically mentions that we have added boundaries, but the sample code in the chapter doesn't add it.